Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed hard-coded AWS account id in examples #275

Conversation

msharma24
Copy link
Contributor

Removed hard-coded AWS account ID from examples/complete and added data resource to lookup current AWS account

Description

Remove hard-coded AWS account ID from examples/complete and added data resource to lookup current AWS account

Motivation and Context

Unable to build the examples/complete main.tf because the AWS account id is hard-coded.

Breaking Changes

No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@msharma24 msharma24 changed the title Remove hardcoded AWS account and added data resource to lookup current AWS Account fix Remove hard-coded AWS account and added data resource to lookup current AWS Account Mar 4, 2022
@msharma24 msharma24 changed the title fix Remove hard-coded AWS account and added data resource to lookup current AWS Account fix Remove hard-coded AWS account id Mar 6, 2022
@antonbabenko antonbabenko changed the title fix Remove hard-coded AWS account id fix: Removed hard-coded AWS account id in examples Mar 28, 2022
@antonbabenko antonbabenko merged commit 5ab1383 into terraform-aws-modules:master Mar 28, 2022
antonbabenko pushed a commit that referenced this pull request Mar 28, 2022
### [3.0.1](v3.0.0...v3.0.1) (2022-03-28)

### Bug Fixes

* Removed hard-coded AWS account id in examples ([#275](#275)) ([5ab1383](5ab1383))
@antonbabenko
Copy link
Member

This PR is included in version 3.0.1 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants